De-parallelize integration test #1744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise Windows runners may raise this exception: E UnicodeEncodeError: 'charmap' codec can't encode characters in position 890-897: character maps to <undefined>
umbynos
reviewed
May 31, 2022
Co-authored-by: Umberto Baldi <34278123+umbynos@users.noreply.github.com>
umbynos
approved these changes
May 31, 2022
per1234
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
Integration tests are no more parallelized and the test output Is displayed for better debugging.
The parallelization is no more needed since they are split using GitHub actions runners.
What is the current behavior?
Tests are run in "parallel" (in reality only one test per runner so there is no effective parallelization) and the output is hidden.
What is the new behavior?
Tests are run sequentially and the output is visible.
Does this PR introduce a breaking change, and is titled accordingly?
No
Other information:
Some tests are still hidden because their output is UTF-8 and it seems to cause some python exceptions on Windows runners: while waiting for a better solution I've opted for the quick-and-dirty workaround.